Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C civicrm-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CiviCRM
  • civicrm-core
  • Merge requests
  • !17500

Open
Created Jun 05, 2020 by Michael O'Toole@MikeyMJCOOwner
  • Report abuse
Report abuse

[Ref] Throw exceptions from Authorize.net rather than return errors

  • Overview 2
  • Commits 1
  • Changes 1

Created by: eileenmcnaughton

Overview

This is part of 'modelling good behaviour' - curently doPayment converts the errors to thrown exceptions, but the recommendation is that the payment processor functions should throw exceptions themselves. If they do they willl bypass the doPayment handling, but acheive the same thing

Before

return self::error(9001, 'Payment interval must be at least one week');

is received by CRM_Core_Payment::doPayment and which then throws an exception

After

Exception thrown in the first place

Technical Details

@KarinG basically we need to do this in a bunch of places - in core & also encourage extension writers to do so.

Comments

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/eileenmcnaughton/renew_can