Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C civicrm-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CiviCRM
  • civicrm-core
  • Merge requests
  • !17502

Open
Created Jun 05, 2020 by Michael O'Toole@MikeyMJCOOwner
  • Report abuse
Report abuse

Fix probably-unused core payment processors to throw extensions

  • Overview 1
  • Commits 1
  • Changes 2

Created by: eileenmcnaughton

Overview

Make FirstData and Payjunction comply with our error handling expectations

Before

return self::errorExit(9003, $message);

After

throw new PaymentProcessorException($message, 9003);

Technical Details

These 2 processors are probably entirely unused and are not enabled on new installs. However, as they are still in core, and removing them will take a plan + time, we should have them model 'good behaviour' - ie throwing exceptions rather than returning errors

Comments

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/eileenmcnaughton/first