Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C civicrm-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CiviCRM
  • civicrm-core
  • Merge requests
  • !17503

Open
Created Jun 05, 2020 by Michael O'Toole@MikeyMJCOOwner
  • Report abuse
Report abuse

Move FirstData payments into a core-extension

  • Overview 3
  • Commits 2
  • Changes 11

Created by: eileenmcnaughton

Overview

Move Legacy FirstData processor to an core-extension

This is one of a handful of processors that is in core but we believe is no longer in use.

Before

FirstData is in main CRM_Core_Payment folder, but not enabled on new installs

After

FirstData is moved to a core-extension, enabled only on upgrade for sites with existing payments linked to processors of FirstData type. Extraneous FirstData payment processor records removed on other sites.

Technical Details

Upgrade script not yet written but the plan is 1) Look for any instances of PaymentProcessors linked to the FirstData class. If none exist delete the FirstData row from the civicrm_payment_processor_type table 2) Look for any financial_trxn records linked to any existing FirstData payment processor instance (recurrings are not possible here). If none exist delete from civicrm_payment_processor & civicrm_payment_processor_type 3) If there IS a processor row then install the extension. The install makes no DB changes as this extension is only intended for those who already depend on it existing. As such it is also hidden.

Comments

Planning for complete removal from core is punted for now. However, we should start to see stats on whether it is enabled  for anyone over time. We could use status checks in the extension for messaging, once we have it.
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/eileenmcnaughton/second