Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C civicrm-core
  • Project information
    • Project information
    • Activity
    • Labels
    • Planning hierarchy
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • CiviCRM
  • civicrm-core
  • Merge requests
  • !17506

Open
Created Jun 05, 2020 by Michael O'Toole@MikeyMJCOOwner
  • Report abuse
Report abuse

Payment Propertybag remove warning

  • Overview 2
  • Commits 1
  • Changes 1

Created by: mattwire

Overview

Remove the "We have merged input params..." warning from mergeLegacyInputParams because:

  1. We get a separate message logged for every property that was merged.
  2. We're going to be using this function for a long time and the message doesn't really give us anything useful - if the function is called and nothing is merged then we don't have any code that needs fixing.
  3. The developer that sees this error probably can't do anything to resolve the issue.

Before

Warning triggered everytime function is called + Warning for each property that was actually merged.

After

Warning for each property that was actually merged.

Technical Details

Comments

@eileenmcnaughton @artfulrobot

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/mattwire/propertybagremovewarning